[ABW-4084] Add security shield details screen #1342
Conversation
|
|
||
| @Composable | ||
| fun Threshold.display(): String = when (this) { | ||
| is Threshold.All -> "ALL" |
There was a problem hiding this comment.
I think this exists in crowdin, although with a different screen name.
There was a problem hiding this comment.
Right, and it's not all caps: shieldWizardRegularAccess_thresholdDescription_all, but still it might be ok to reuse it I think.
| @@ -0,0 +1,100 @@ | |||
| package com.babylon.wallet.android.presentation.common.securityshields | |||
There was a problem hiding this comment.
I would split the composables on their own files. since they are already in a common.securityshields package.
There was a problem hiding this comment.
good point but in which way though?
|
|
||
| @Composable | ||
| fun Threshold.display(): String = when (this) { | ||
| is Threshold.All -> "ALL" |
There was a problem hiding this comment.
A reminder to add this to crowdin.
|
|
||
| @Composable | ||
| fun Threshold.display(): String = when (this) { | ||
| is Threshold.All -> "ALL" |
There was a problem hiding this comment.
Right, and it's not all caps: shieldWizardRegularAccess_thresholdDescription_all, but still it might be ok to reuse it I think.
giannis-rdx
force-pushed
the
feature/ABW-4084-security-shield-details-screen
branch
from
9d78d43 to
25f7052
Compare
giannis-rdx
force-pushed
the
feature/ABW-4084-security-shield-details-screen
branch
from
25f7052 to
075fc98
Compare
|
giannis-rdx
deleted the
feature/ABW-4084-security-shield-details-screen
branch
Description
This PR solves adds the Security Shield details screen. (read commit messages for more details).
This PR is on top of this PR. So you can apply a shield and test the details screen.
Future tasks (NOT for this PR):
How to test
Video
here
PR submission checklist