[ABW-1913] Apply divisibility to guaranteed amount #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
force-pushed
the
ABW-1913_Fungible-Rounding
branch
2 times, most recently
from
e4ba835 to
4ee8147
Compare
kugel3
force-pushed
the
ABW-1913_Fungible-Rounding
branch
from
4ee8147 to
371d8ad
Compare
|
This functionality is partly already existing, partly included in #1010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1913
Description
After applying a guarantee, we should round the amount according to the divisibility of the resource.
How to test
-> The resulting amount should not have more decimals than the divisibility dictates
Screenshot
Coming
PR submission checklist