Linked connector not restoring after iCloud restore

[GhenadieVP]

Connect to the P2PLinks during the profile Restore from Backup flow.

Changes

• Don't remove the P2PLinks from the Profile when deleting the Wallet, so those are not lost when trying to Restore from Backup.
• When user starts the Restore from Backup flow, the Wallet pro-actively connects to the P2PLinks from the selected Profile.
• While it was possible to connect to P2PLinks only when landing on home screen, connecting pro-actively in Restore from Backup flow, would make the experience of needing to use a Ledger device during the flow a lot better.
• If user leaves the Restore from Backup flow, RadixConnect will remove the established connections.

Demo

Screen.Recording.2024-01-31.at.08.35.01.mov

[Sajjon]

cant remember now, but what are we infact awaiting here? looks wrong? This mean that send(.internal(.delay..(.importMnemonicsFlow)) event is not emitted until radixConnectClient.connectToP2PLinks has finished? So what happens if you quit Chrome and redo your demo in the video? Will this RestoreProfileFromBackupCoordinator reducer wait forever until connected? Or are we using unstructured concurrency inside connectToP2PLinks ensuring it will not be 'blocking"? Otherwise, perhaps this try await inside this run must change, e.g. to a run {}.concat {} or whatever the syntax is block, or possible even Task (unstructured concurrency)?

[GhenadieVP]

Will this RestoreProfileFromBackupCoordinator reducer wait forever until connected?

No, connectToP2PLinks calls the try await rtcClients.connect(password, waitsForConnectionToBeEstablished: false). if waitsForConnectionToBeEstablished == false there is no actual async code path:

	public func connect(
		_ linkPassword: ConnectionPassword,
		waitsForConnectionToBeEstablished: Bool = false
	) async throws {
		guard !clients.contains(where: { $0.key == linkPassword }) else {
			loggerGlobal.notice("Ignored connecting RTCClient with connectionPassword/id: \(linkPassword), since it is already in RTCClients.clients")
			return
		}
		let client = try makeRTCClient(linkPassword)
		if waitsForConnectionToBeEstablished {
			try await client.waitForFirstConnection()
		}
		add(client)
	}

[CyonAlexRDX]

LGTM