Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared pool unit view + dapp #995

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Shared pool unit view + dapp #995

merged 11 commits into from
Jan 26, 2024

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Jan 23, 2024 •
edited
Loading

  • Use the shared representation of pool unit view across different screens - Account Details, Pool Unit details, Transaction Review.
  • Added the dApp resolution for the pool resource, and display the dApp name under the pool name.
  • Implemented navigation to Pool Unit details from TX review screen.

Demo

RPReplay_Final1706089587.MP4

@GhenadieVP GhenadieVP marked this pull request as ready for review January 24, 2024 08:44
@GhenadieVP GhenadieVP changed the title WIP - shared pool unit view + dapp Shared pool unit view + dapp Jan 24, 2024
kugel3
kugel3 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@kugel3 kugel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but I really don't like that redemption value is a string

CyonAlexRDX
CyonAlexRDX approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@GhenadieVP GhenadieVP merged commit 0679737 into main Jan 26, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the shared_pool_unit_view branch January 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kugel3 kugel3 kugel3 approved these changes

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GhenadieVP @CyonAlexRDX @kugel3