add `validation_for_addition_of_factor_source_of_kind_to_confirmation…

…_override` tests
radixdlt · Nov 26, 2024 · f454d9b · f454d9b
1 parent 8d6839e
commit f454d9b
Showing 1 changed file with 48 additions and 4 deletions.
diff --git a/crates/rules/src/matrix_builder.rs b/crates/rules/src/matrix_builder.rs
@@ -983,7 +983,7 @@ mod tests {
 
             #[test]
             fn validation_for_addition_of_factor_source_of_kind_to_recovery_override_empty() {
-                let mut sut = make();
+                let sut = make();
                 let test = |kind: FactorSourceKind, should_be_ok: bool| {
                     let is_ok = sut
                         .validation_for_addition_of_factor_source_of_kind_to_recovery_override(kind)
@@ -997,9 +997,6 @@ mod tests {
                 test(FactorSourceKind::Passphrase, false);
                 test(FactorSourceKind::OffDeviceMnemonic, true);
                 test(FactorSourceKind::TrustedContact, true);
-
-                sut.add_factor_source_to_recovery_override(FactorSourceID::sample_ledger())
-                    .unwrap();
             }
 
             #[test]
@@ -1024,6 +1021,53 @@ mod tests {
             }
         }
 
+        mod confirmation {
+            use super::*;
+
+            #[test]
+            fn validation_for_addition_of_factor_source_of_kind_to_confirmation_override_empty() {
+                let sut = make();
+                let test = |kind: FactorSourceKind, should_be_ok: bool| {
+                    let is_ok = sut
+                        .validation_for_addition_of_factor_source_of_kind_to_confirmation_override(
+                            kind,
+                        )
+                        .is_ok();
+                    assert_eq!(is_ok, should_be_ok);
+                };
+                test(FactorSourceKind::Device, true);
+                test(FactorSourceKind::LedgerHQHardwareWallet, true);
+                test(FactorSourceKind::ArculusCard, true);
+                test(FactorSourceKind::SecurityQuestions, true);
+                test(FactorSourceKind::Passphrase, true);
+                test(FactorSourceKind::OffDeviceMnemonic, true);
+                test(FactorSourceKind::TrustedContact, false);
+            }
+
+            #[test]
+            fn validation_for_addition_of_factor_source_of_kind_to_confirmation_override_single_recovery(
+            ) {
+                let mut sut = make();
+                sut.add_factor_source_to_confirmation_override(FactorSourceID::sample_ledger())
+                    .unwrap();
+                let test = |kind: FactorSourceKind, should_be_ok: bool| {
+                    let is_ok = sut
+                        .validation_for_addition_of_factor_source_of_kind_to_confirmation_override(
+                            kind,
+                        )
+                        .is_ok();
+                    assert_eq!(is_ok, should_be_ok);
+                };
+                test(FactorSourceKind::Device, true);
+                test(FactorSourceKind::LedgerHQHardwareWallet, true);
+                test(FactorSourceKind::ArculusCard, true);
+                test(FactorSourceKind::SecurityQuestions, true);
+                test(FactorSourceKind::Passphrase, true);
+                test(FactorSourceKind::OffDeviceMnemonic, true);
+                test(FactorSourceKind::TrustedContact, false);
+            }
+        }
+
         mod primary {
             use super::*;