Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Preparations for factor instances provider #17

Merged
merged 114 commits into from
Oct 9, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Oct 9, 2024

This is the redo_rere branch with rm -rf src/factor_instances_provider commit ( 7c633ee ) on top. Which I will then revert in a new PR, which will be the FactorInstancesProvider PR...

@CyonAlexRDX CyonAlexRDX marked this pull request as ready for review October 9, 2024 12:10
@CyonAlexRDX CyonAlexRDX merged commit 66189e9 into main Oct 9, 2024
4 checks passed
@CyonAlexRDX CyonAlexRDX deleted the preparations_for_factor_instances_provider branch October 9, 2024 12:16
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 75.42857% with 43 lines in your changes missing coverage. Please review.

Project coverage is 94.3%. Comparing base (c7839f4) to head (7c633ee).
Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
src/types/new_types/factor_instances.rs 48.2% 15 Missing ⚠️
src/types/new_types/accounts.rs 52.6% 9 Missing ⚠️
src/types/new_types/securified_account.rs 73.9% 6 Missing ⚠️
src/types/new_types/securified_entities.rs 66.6% 6 Missing ⚠️
src/types/new_methods_on_sargon_types.rs 0.0% 3 Missing ⚠️
src/types/new_types/securified_accounts.rs 87.5% 2 Missing ⚠️
src/types/new_types/unsecurified_entity.rs 90.4% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #17     +/-   ##
=======================================
- Coverage   96.1%   94.3%   -1.8%     
=======================================
  Files         49      57      +8     
  Lines       1136    1288    +152     
=======================================
+ Hits        1092    1215    +123     
- Misses        44      73     +29     
Files with missing lines Coverage Δ
src/derivation/collector/key_derivation_outcome.rs 100.0% <100.0%> (ø)
src/derivation/collector/key_ring.rs 100.0% <100.0%> (ø)
src/derivation/collector/keys_collector.rs 96.9% <100.0%> (+0.1%) ⬆️
src/derivation/collector/keys_collector_state.rs 100.0% <100.0%> (ø)
...raction/requests/mono_factor_sign_request_input.rs 100.0% <ø> (ø)
...raction/requests/transaction_sign_request_input.rs 100.0% <ø> (ø)
src/signing/petition_types/factor_list_kind.rs 100.0% <100.0%> (ø)
src/types/new_types/u30.rs 100.0% <100.0%> (ø)
src/types/new_types/veci.rs 100.0% <100.0%> (ø)
src/types/new_types/securified_accounts.rs 87.5% <87.5%> (ø)
... and 6 more

... and 2 files with indirect coverage changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants