-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Self { kind, id } | ||
} | ||
|
||
pub fn device(id: u8) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ever use two?
Self::new(FactorSourceKind::TrustedContact, id) | ||
} | ||
|
||
pub fn security_questions(id: u8) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont use two!
Self::new(FactorSourceKind::Device, id) | ||
} | ||
|
||
pub fn ledger(id: u8) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets use ledger
and ledger_other
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge arculus
and ledger
into a new proto-type. Hardware
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
- Coverage 93.8% 93.1% -0.7%
=======================================
Files 24 26 +2
Lines 938 925 -13
=======================================
- Hits 880 862 -18
- Misses 58 63 +5
|
No description provided.