-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## migrate_from_other_repo #4 +/- ##
=======================================================
Coverage 97.2% 97.2%
=======================================================
Files 37 40 +3
Lines 949 988 +39
=======================================================
+ Hits 923 961 +38
- Misses 26 27 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests which asserts array of FAILED neglected factors!
@@ -0,0 +1,19 @@ | |||
use crate::prelude::*; | |||
|
|||
pub trait FactorSourceReferencing: std::hash::Hash + PartialEq + Eq + Clone { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make crate pub?
pub type NeglectedFactorInstance = AbstractNeglectedFactor<HierarchicalDeterministicFactorInstance>; | ||
|
||
#[derive(Clone, PartialEq, Eq, Hash)] | ||
pub struct AbstractNeglectedFactor<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc? Crate pub inst of pub?
@@ -147,7 +155,7 @@ mod tests { | |||
FactorSourceIDFromHash::fs0(), | |||
); | |||
|
|||
sut.did_skip(&factor_instance, false); | |||
sut.skip(&factor_instance, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test for failure instead of skip
@@ -1,36 +1,43 @@ | |||
use crate::prelude::*; | |||
|
|||
#[derive(Clone, PartialEq, Eq, derive_more::Debug)] | |||
pub enum SignWithFactorSourceOrSourcesOutcome { | |||
pub enum SignWithFactorsOutcome { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc?
No description provided.