Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml identifier with dashes needs to be escaped in single quotes #55

Closed
annajolly opened this issue Oct 22, 2024 · 2 comments · Fixed by #56
Closed

Yaml identifier with dashes needs to be escaped in single quotes #55

annajolly opened this issue Oct 22, 2024 · 2 comments · Fixed by #56

Comments

@annajolly
Copy link
Contributor

When types are generated from a yaml file that has dashes in the identifier, the identifier is not wrapped in single quotes, leading to a typescript error:

What I get:
Screenshot 2024-10-22 at 6 31 25 PM

What I expect:
Screenshot 2024-10-22 at 6 31 42 PM

I've already created a fix for this, but need to be granted write permissions to this repo.

P.S. Hi from Unity, Jason!

@rametta
Copy link
Owner

rametta commented Oct 23, 2024

Hey Anna! Great catch on that.

To open a PR here you can create a fork and then open a cross-repo PR and that's usually how it's done for open source repos. Let me know if you need any other info, I'm sure I'll merge it as soon as it's available

@annajolly
Copy link
Contributor Author

Done! #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants