Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types generator when yaml file key includes dashes #56

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix types generator when yaml file key includes dashes #56

merged 2 commits into from
Oct 23, 2024

Conversation

annajolly
Copy link
Contributor

@annajolly annajolly commented Oct 23, 2024 •
edited
Loading

Fix types generator when yaml file key includes dashes

Fixes error where yaml identifiers with dashes cause broken typescript files.

Fixes #55

  • I have added or updated unit tests for this change.
  • I have updated the changelog with info about the changes in this PR

@annajolly annajolly mentioned this pull request Oct 23, 2024
Closed
rametta
rametta reviewed Oct 23, 2024
View reviewed changes
src/common/types.ts Outdated Show resolved Hide resolved
rametta
rametta approved these changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@rametta rametta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rametta rametta merged commit 8475614 into rametta:main Oct 23, 2024
3 checks passed
@rametta
Copy link
Owner

rametta commented Oct 23, 2024

Thanks @annajolly - it should be published now in npm under version 3.5.2
(I accidentally published 3.5.1 with an empty project)

@annajolly annajolly deleted the fix/identifier-with-dashes branch October 24, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rametta rametta rametta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yaml identifier with dashes needs to be escaped in single quotes
2 participants
@annajolly @rametta