Refactor makeRequestsPropertyAssignment to use loop over HTTP methods #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @moetazbrayek1, thanks for the PR. it seems the build fails with typescript types errors. Please take a look: |
|
okay let me double check the tests |
Just to clarify, it is not the tests failing, it is the build/compilation of typescript failing because of type mismatches |
|
Fixed the typing issue. Could you check now? |
rametta
reviewed
Dec 5, 2023
|
@rametta you can check now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Simplify makeRequestsPropertyAssignment Function
This PR refactors the
makeRequestsPropertyAssignmentfunction to use a loop over HTTP methods, reducing repetitiveifstatements and improving code maintainability. The functionality remains unchanged, ensuring backward compatibility. Unit tests have been checked to confirm they pass with the refactor.