Add missing include for calling std::iota() #17983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
bdice
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Thanks @davidwendt. This is probably because I cleaned up extraneous includes in RMM: rapidsai/rmm#1821
PointKernel
approved these changes
Feb 11, 2025
|
/merge |
mhaseeb123
approved these changes
Feb 12, 2025
|
/merge |
rapids-bot
bot
merged commit 4e79029
into
rapidsai:branch-25.04
108 of 109 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent build failure in #17600 indicated undefined
std::iota. This PR adds the appropriate#include <numeric>in the source files where this is called.Checklist