Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Column.serialize to cudf-polars #17990

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Add Column.serialize to cudf-polars #17990

merged 6 commits into from
Feb 13, 2025

Conversation

rjzamora
Copy link
Member

Description

It will be useful to serialize individual columns during multi-GPU cudf-polars execution. For example, the Expr-decomposition approach proposed in #17941 may "require" Column serialization (or an ugly workaround).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added feature request New feature or request non-breaking Non-breaking change cudf.polars Issues specific to cudf.polars labels Feb 12, 2025
@rjzamora rjzamora self-assigned this Feb 12, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 12, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 12, 2025
@rjzamora
Copy link
Member Author

cc @TomAugspurger (In case you are interested/available) :)

@rjzamora rjzamora added the 2 - In Progress Currently a work in progress label Feb 12, 2025
@rjzamora rjzamora marked this pull request as ready for review February 12, 2025 05:46
@rjzamora rjzamora requested a review from a team as a code owner February 12, 2025 05:46
@rjzamora rjzamora requested review from bdice and Matt711 February 12, 2025 05:46
Matt711
Matt711 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think CI failures are unrelated

python/cudf_polars/cudf_polars/containers/column.py Outdated Show resolved Hide resolved
TomAugspurger
TomAugspurger reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice overall. One question about typing.

python/cudf_polars/cudf_polars/containers/column.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/containers/column.py Outdated Show resolved Hide resolved
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Feb 13, 2025
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 3fa56d0 into rapidsai:branch-25.04 Feb 13, 2025
111 checks passed
@rjzamora rjzamora deleted the serialize-columns branch February 13, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@TomAugspurger TomAugspurger TomAugspurger left review comments

@Matt711 Matt711 Matt711 approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@rjzamora rjzamora

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cudf.polars Issues specific to cudf.polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjzamora @wence- @TomAugspurger @Matt711