-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use raft::host_span instead of const reference to std::vector #4931
base: branch-25.04
Are you sure you want to change the base?
Conversation
/merge |
Question: why dont we use |
Oh, is it available now? I was thinking about using raft::host_span/device_span first and switch to cuda::std::span (and std::span which is from C++20) once they become available. I will replace raft span with cuda::std::span in a separate PR. How do we distinguish host_span and device_span in cuda::std::span? |
There is currently no way, but AFAIK raft also only has type aliases which boil down to the same type |
https://github.com/rapidsai/raft/blob/branch-25.04/cpp/include/raft/core/span.hpp#L50 In raft, I think we will stay little longer with raft::host_span/device_span till we get a solution for this (maybe cuda::std::span and std::span). |
/merge |
This PR updates functions to consistently take raft::host_span instead of std::vector const& (we have been mixing the two); except for public functions in graph_functions.hpp.
Marked as breaking as this PR updates functions under include/cugraph/utilities/device_comm.hpp,shuffle_comm.cuh, but we don't expect public users to directly call these utility functions.