Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-25.02 to branch-25.04 #1532

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 4, 2025

Manual forward merge from 25.02 to 25.04. This PR should not be squashed.

bdice and others added 3 commits February 1, 2025 03:51
Fixes undesired CI skips in rapidsai#1523.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#1527
…#1523)

Follow up to rapidsai#1514

Addressing the review in rapidsai#1514 (comment) by ensuring the Cython bindings return pylibcudf objects where possible instead of python objects (like cudf Python columns) so we can also have better return annotations for these methods where appropriate. Subsequently, the conversion from pylibcudf to cudf Python has been moved to the cuspatial Python layer.

Additionally, this PR will be necessary for rapidsai/cudf#17760 not to break cuspatial

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Michael Wang (https://github.com/isVoid)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#1523
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 4, 2025
@mroeschke
Copy link
Contributor

Thanks for the follow up!

@raydouglass raydouglass merged commit 9a4970f into rapidsai:branch-25.04 Feb 4, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants