New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: disallow fallback to Make in Python builds #124

Draft

jameslamb wants to merge 1 commit into rapidsai:main from jameslamb:no-make-fallback

Member

jameslamb commented Jan 31, 2025

Contributes to rapidsai/build-planning#146

Proposes:

setting [tool.scikit-build].ninja.make-fallback = false, so scikit-build-core will not silently fallback to using GNU Make if ninja is not available


          disallow fallback to Make in Python builds

e7d2dcf

jameslamb added improvement non-breaking labels

jameslamb mentioned this pull request

Ensure ninja is used in wheel builds 🥷 rapidsai/build-planning#146

Open

Member

jakirkham commented Feb 1, 2025

Thanks James! 🙏

Can you please update the copyright range header for pyproject.toml as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement non-breaking