Patch Distributed UCX comms to allow configuring connect timeout #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
feature request
pentschev
commented
Jan 21, 2025
| cuda_visible_device, cuda_context_created.device_info, os.getpid() | ||
| ) | ||
|
|
||
| connect_timeout = dask.config.get("distributed.comm.ucx.connect-timeout", None) |
| # that don't override ucx_config or existing slots in the | ||
| # environment, so the user's external environment can safely | ||
| # override things here. | ||
| ucp.init(options=ucx_config, env_takes_precedence=True, connect_timeout=connect_timeout) |
There was a problem hiding this comment.
And connect_timeout is added to this line as well. This and the line above are the only changes to the original UCX comms in Distributed.
|
@pentschev can you also provide an example of using this config option ? |
quasiben
approved these changes
Jan 21, 2025
galipremsagar
approved these changes
Jan 21, 2025
In Dask you just either set: Or via environment variable: I think here is not the place to document that though, we should do that in Dask-CUDA. I'll try to do that tomorrow. |
|
Thanks @quasiben and @galipremsagar . |
|
/merge |
|
As promised (a day late), I've opened rapidsai/dask-cuda#1428 to include this into Dask-CUDA docs. |
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Jan 23, 2025
A new configuration to the UCX comms module was introduced in rapidsai/rapids-dask-dependency#80, this is designed to help with timeouts in larger clusters, and sometimes even small ones depending on the architecture. This change documents that new configuration. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) URL: #1428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is required for RAPIDS 25.02, therefore we cannot upstream and wait for a Distributed release on time for the RAPIDS release.
The code here is a verbatim copy of Distributed's ucx.py, only adding a new variable
distributed.comm.ucx.connect-timeoutthat allows controlling the timeout of UCX exchange peer info procedure (implemented in rapidsai/ucx-py#1103).