Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON encoder #6

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Add JSON encoder #6

merged 7 commits into from
Jun 11, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

This command produces JSON output to be consumed by shell scripts via the jq command.

@KyleFromNVIDIA
Add JSON encoder
4efef52 
This command produces JSON output to be consumed by shell scripts
via the jq command.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner June 11, 2024 13:53
@KyleFromNVIDIA KyleFromNVIDIA requested a review from jameslamb June 11, 2024 14:11
jameslamb
jameslamb requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you please add something in the README documenting the existence of this entrypoint?

Before I review further, I'd also like to hear your opinion on my proposal to just use json.dumps(dataclasses.asdict()) instead of a custom encoder.

src/rapids_metadata/json.py Outdated Show resolved Hide resolved
@KyleFromNVIDIA KyleFromNVIDIA requested a review from jameslamb June 11, 2024 14:59
jameslamb
jameslamb requested changes Jun 11, 2024
View reviewed changes
src/rapids_metadata/json.py Outdated Show resolved Hide resolved
@KyleFromNVIDIA KyleFromNVIDIA requested a review from jameslamb June 11, 2024 19:59
@KyleFromNVIDIA KyleFromNVIDIA merged commit e52cb57 into rapidsai:main Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleFromNVIDIA @jameslamb