Use new rapids-logger library #1808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
CMake
Python
|
/ok to test |
8 similar comments
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
vyasr
force-pushed
the
feat/rapids_logger_library
branch
from
a7b1c85 to
255d96a
Compare
|
/ok to test |
vyasr
commented
Feb 4, 2025
Comment on lines
+15
to
+18
|
|
||
| set(rapids-cmake-repo "vyasr/rapids-cmake") | ||
| set(rapids-cmake-branch "feat/rapids_logger_library") | ||
|
|
There was a problem hiding this comment.
This suggestion should be applied as a final change on this PR before merging.
Suggested change
| set(rapids-cmake-repo "vyasr/rapids-cmake") | |
| set(rapids-cmake-branch "feat/rapids_logger_library") |
Matt711
reviewed
Feb 5, 2025
bdice
reviewed
Feb 5, 2025
jameslamb
reviewed
Feb 5, 2025
Matt711
approved these changes
Feb 6, 2025
bdice
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
I have a few small comments, mostly replies to existing threads. I have nothing else significant to add here. @vyasr Please take a pass or two through the open threads and get an approval from @jameslamb before merging.
jameslamb
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change helps completely insulate rmm (and transitively) the rest of RAPIDS from fmt and spdlog as dependencies, thereby solving a large number of issues around ABI stability, symbol visibility, package clobbering, and more. See rapidsai/build-planning#104 for more information.
Checklist