ratgdo32disco #337
Merged
ratgdo32disco #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce to increase slider resolution
bdraco
reviewed
Nov 10, 2024
bdraco
reviewed
Nov 10, 2024
bdraco
reviewed
Nov 10, 2024
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
for more information, see https://pre-commit.ci
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Ceilings that are higher than the sensor capabilities result in out of range (-1) readings. Daylight, water on the floor and other environment changes can also cause the sensor to read out of range. This change results in 30 readings of -1 to be VehicleDetected false.
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
former logic assumed it was the last distance found, which turns out to not always be the case. Implementing @dkerr64 logic from ratgdo/homekit-ratgdo32#16
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@bdraco okay with you to merge this PR? |
bdraco
approved these changes
Jan 20, 2025
LGTM. Also quick note that anything with conflicts doesn’t show up in my review queue |
The throttle filter has a side effect of not updating the value when measurements are out of range. switching to throttle_average is simpler and solves this problem
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
PaulWieland
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.