Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos and leader name for the Kongolese #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mirror8492
Copy link
Contributor

Corrected the leader's name (Queen Nzinga Mbande as opposed to King Mvemba a Nzinga) and some typos

Corrected the leader's name (Queen Nzinga Mbande as opposed to king Mvemba a Nzinga) and some typos
@yairm210
Copy link
Collaborator

yairm210 commented Jul 9, 2024

These are good fixes, but will break existing translations
Ideally this text should be replaced across all translation files as well, which something to do automatically and not manually

@SeventhM
Copy link
Collaborator

@yairm210 question: Is there a workflow to add to help do that automatically? I'm pretty sure Unciv does it automatically, but I never checked if that's with a workflow or during the build

@yairm210
Copy link
Collaborator

No I do "replace all" in the IDE when I want to change a text that has translations 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants