Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trireme fix penalty #281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Trireme fix penalty #281

wants to merge 1 commit into from

Conversation

DeStup
Copy link
Contributor

@DeStup DeStup commented Mar 2, 2025

  1. removed penalty vs cities for trireme
  2. I also noticed that we don't have this penalty for Melee Water. And I do not know how to add it.
    image
    [-3] Movement <vs cities> <when attacking> doesn't work when "Can move after attacking" enabled i quess

@SeventhM
Copy link
Collaborator

SeventhM commented Mar 2, 2025

2. [-3] Movement <vs cities> <when attacking> doesn't work when "Can move after attacking" enabled i quess

I think you want a triggerable here. So [This unit] loses [2] movement <upon attacking>. Annoyingly, upon attacking is not a trigger conditional

@DeStup
Copy link
Contributor Author

DeStup commented Mar 2, 2025

  1. [-3] Movement <vs cities> <when attacking> doesn't work when "Can move after attacking" enabled i quess

I think you want a triggerable here. So [This unit] loses [2] movement <upon attacking>. Annoyingly, upon attacking is not a trigger conditional

That was the first thing I tried, and it didn't work either (
Unciv_HbVPzVfy8M

@SeventhM
Copy link
Collaborator

SeventhM commented Mar 3, 2025

Well, yeah, obviously not. Like I said, upon attacking doesn't exist yet, surprisingly enough. <upon damaging a [mapUnitFilter] unit> is the closest we have

@DeStup
Copy link
Contributor Author

DeStup commented Mar 11, 2025

Well, yeah, obviously not. Like I said, upon attacking doesn't exist yet, surprisingly enough. <upon damaging a [mapUnitFilter] unit> is the closest we have

I haven't studied the code to add a new trigger yet (shame on me).

But maybe then we want to give a debuff to other Melee ships, like the trireme (-33% vs cities)?

upd. Or maybe we should remove all movement after the attack. The penguin gave a good take that this is very strong for sequence turns, compared to simultaneous turns in the lekmode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants