-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hypercall-based PCI CAM and transport for x86-64 pKVM. #164
Conversation
a40ff9b
to
eda68e0
Compare
9942721
to
81a325f
Compare
630eabd
to
3d2cc18
Compare
9168099
to
38f3e51
Compare
Co-authored-by: Grzegorz Jaszczyk <jaszczyk@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for preparing this PR!
@@ -0,0 +1,124 @@ | |||
//! x86-64 specific transports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe "hypercall based, x86-64 specific transport"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting that other x86-64 specific transports could also go in this module in future, for example if we have a PCI CAM using x86 IO ports.
VMs running under pKVM on x86-64 cannot do MMIO, so a hypercall based transport is provided instead.