feat: motion support ref #61

zombieJ · 2025-02-10T11:23:51Z

Summary by CodeRabbit

Refactor
- 优化了运动组件的内部逻辑，提升了类型安全和动画状态检测的准确性，同时确保了动画效果和渲染行为与之前保持一致。
Tests
- 更新了相关测试用例，以匹配新改动，确保组件在各场景下均能稳定运行。

vercel · 2025-02-10T11:23:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
motion	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 11:29am

coderabbitai · 2025-02-10T11:24:00Z

Warning

Rate limit exceeded

@zombieJ has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9ac92fc and f642934.

📒 Files selected for processing (1)

package.json (2 hunks)

Walkthrough

本次提交增强了 CSSMotion 组件的类型安全性。新增了 CSSMotionRef 接口，用于定义包含 nativeElement 和 inMotion 方法的引用对象。组件通过 React.useImperativeHandle 返回该结构化对象，并更新了 forwardRef 的类型声明。测试文件也相应调整了引用和断言，确保使用新的 CSSMotionRef 类型，而功能行为保持一致。

Changes

文件 / 文件组	更改摘要
`src/CSSMotion.tsx`	新增 `CSSMotionRef` 接口；更新 `forwardRef` 签名；使用 `useImperativeHandle` 返回 `{ nativeElement, inMotion }` ；重组内部逻辑
`tests/CSSMotion.spec.tsx` 和 `tests/StrictMode.spec.tsx`	更新测试引用类型，从 `React.createRef()` 改为 `React.createRef<CSSMotionRef>()`；调整断言以访问 `nativeElement` 属性

Sequence Diagram(s)

sequenceDiagram
    participant App as 应用组件
    participant CSSMotion as CSSMotion组件
    participant Ref as 组件Ref
    participant Test as 测试代码
    App->>CSSMotion: 渲染组件
    CSSMotion->>Ref: 用useImperativeHandle暴露{ nativeElement, inMotion }
    Test->>Ref: 访问nativeElement和调用inMotion方法
    Ref-->>Test: 返回nativeElement以及运动状态

Possibly related PRs

refactor: use rc-util getNodeRef #57: 该 PR 涉及对 CSSMotion 组件引用管理的修改，直接关联到新引入的 CSSMotionRef 接口。
feat: Remove findDOMNode from rc-css-motion #59: 该 PR 关注于增强 CSSMotion 组件的引用处理，涉及到与本 PR 相似的引用管理改进。

Poem

我是一只跳跃的小兔子，
在代码丛中寻找光明，
新接口如胡萝卜般美味，
CSSMotion带来奇妙韵律，
编程路上共舞欢欣！ 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-02-10T11:29:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (3ec24ae) to head (f642934).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   98.44%   98.45%           
=======================================
  Files          11       11           
  Lines         386      388    +2     
  Branches      107      107           
=======================================
+ Hits          380      382    +2     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

socket-security · 2025-02-10T11:29:18Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@rc-component/np@1.0.3	Transitive: environment, eval, filesystem, shell, unsafe	`+141`	18.1 MB	zombiej

View full report↗︎

feat: motion support ref

1e8679c

vercel bot deployed to Preview February 10, 2025 11:24 View deployment

test: add test case

9ac92fc

vercel bot deployed to Preview February 10, 2025 11:27 View deployment

chore: add np deps

f642934

vercel bot deployed to Preview February 10, 2025 11:29 View deployment

zombieJ merged commit c487db0 into master Feb 10, 2025
10 checks passed

zombieJ deleted the motion-ref branch February 10, 2025 11:36

This was referenced Feb 10, 2025

refactor: make ref stable #62

Merged

chore: more refs #63

Merged

revert: ref back of func #64

Merged

feat: retire deprecated api #65

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: motion support ref #61

feat: motion support ref #61

zombieJ commented Feb 10, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 10, 2025 •

edited

Loading

coderabbitai bot commented Feb 10, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Feb 10, 2025 •

edited

Loading

socket-security bot commented Feb 10, 2025

feat: motion support ref #61

feat: motion support ref #61

Conversation

zombieJ commented Feb 10, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Feb 10, 2025 • edited Loading

coderabbitai bot commented Feb 10, 2025 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Feb 10, 2025 • edited Loading

Codecov Report

socket-security bot commented Feb 10, 2025

zombieJ commented Feb 10, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 10, 2025 •

edited

Loading

coderabbitai bot commented Feb 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 10, 2025 •

edited

Loading