Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ios build with use_frameworks static #771

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

jeongshin
Copy link
Contributor

Hi Thanks for great library.

This may fix this issue.

I tested on my app with linking static and it works.

Thank you.

Copy link

changeset-bot bot commented Feb 16, 2025

🦋 Changeset detected

Latest commit: 43e6a9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@react-native-documents/picker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vonovak
Copy link
Member

vonovak commented Feb 16, 2025

Hello, and thank you for the PR!

okay, let's give this a go!

@vonovak
Copy link
Member

vonovak commented Feb 16, 2025

@jeongshin the build fails with

/Users/runner/work/document-picker/document-picker/packages/document-picker/ios/RNDocumentPicker.mm:13:9: fatal error: 'react_native_document_picker/react_native_document_picker-Swift.h' file not found
#import <react_native_document_picker/react_native_document_picker-Swift.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

** BUILD FAILED **

can you pls take a look at it?

Thank you!

@vonovak
Copy link
Member

vonovak commented Feb 17, 2025

btw I'd guess that by the time the preprocessor runs, the headers are not yet available; this header is generated by xcode at build time I think

@jeongshin
Copy link
Contributor Author

btw I'd guess that by the time the preprocessor runs, the headers are not yet available; this header is generated by xcode at build time I think

I'm trying to fix the build issue, but I think the build fails even before I can fix the header problem.

I fixed the headers generation issue but stuck on the other problems.

I'll take a look for details on upcoming weekend. I don't have much time on weekdays... 🙏.

Thanks!

@jeongshin
Copy link
Contributor Author

@vonovak I think I fixed the build issue. Tested on forked main branch.

Thanks!

@stephane-r
Copy link

Hi @jeongshin thank you ! Build is success for me too.

@vonovak vonovak merged commit 62794a6 into react-native-documents:main Feb 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'react_native_document_picker-Swift.h' file not found
3 participants