test: Cull some time zones to avoid test failures #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get recurring, random test failures when generating timestamps from certain zones, mostly due to the fact that different databases use different `tzdata` versions and some time zones are particularly troublesome (i.e. America/Mexico_City, which was still on Lunar Mean Time in 1922). Without mapping tzdata used for our tests with the tzdata used by supporting databases, we can't hope to verify proper handling of *all* timezones for *all* edge cases. This update removes time zones which have been known to cause test failures in the past and/or are unlikely to be encountered in the wild by users at this time. Change-Id: Id46b3fadb2d8d9bfaecb8013ca0f69a25ade867f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get recurring, random test failures when generating timestamps from
certain zones, mostly due to the fact that different databases use
different
tzdataversions and some time zones are particularlytroublesome (i.e. America/Mexico_City, which was still on Lunar Mean
Time in 1922). Without mapping tzdata used for our tests with the
tzdata used by supporting databases, we can't hope to verify proper
handling of all timezones for all edge cases. This update removes
time zones which have been known to cause test failures in the past
and/or are unlikely to be encountered in the wild by users at this time.