ui: always delete workspace when deleting workflow #281
Conversation
| @@ -92,7 +92,7 @@ export default function WorkflowActionsPopup({ workflow, className }) { | |||
| content: "Free up disk", | |||
There was a problem hiding this comment.
Technically we shouldn't need this option any more, but it might be useful to keep it for a while for users who have previously deleted the workflow without the workspace
| /> | ||
| </> | ||
| <Message icon warning> | ||
| <Icon name="warning sign" /> |
There was a problem hiding this comment.
Minor: for quota notifications warning message we used warning circle icon, it would be good to keep the same one for consistency.
Actually it would be even better to have a component similar to Notifications which would simply display these kind of messages and select an appropriate icon depending if it's a warning, info or an error. In profile page we use it exactly for this purpose, but it's not ideal since it have an additional logic to display the messages from getNotification selector. I think it would be nice to decouple it and use a dumb notification component everywhere in these kind of cases (something definitely for later)
There was a problem hiding this comment.
Agree! I will open an issue about this
Closes #280
How to test:
Expected result: The workspace is deleted together with the workflow and the workflow duration is shown in both the workflow list and in the details page