-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-848: [release-4.18] csi: update RBACs for CSIAddonsNode #82
DFBUGS-848: [release-4.18] csi: update RBACs for CSIAddonsNode #82
Conversation
This patch adds `watch` and `list` verbs for CSIAddonsNode objects. These permissions are required by the csi-addons sidecar. Ref: csi-addons/kubernetes-csi-addons#765 Signed-off-by: Niraj Yadav <niryadav@redhat.com> (cherry picked from commit a0d2dc6)
generated bundle changes for the csiaddons rbac. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
/lgtm |
@Madhu-1: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle DFBUGS-848: [release-4.18] csi: update RBACs for CSIAddonsNode |
@Madhu-1: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
@black-dragon74: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: black-dragon74, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
803c9f1
into
red-hat-storage:release-4.18
@Madhu-1: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph#204
@black-dragon74 please add the Jira number to the PR title to get this PR merged