Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-848: [release-4.18] csi: update RBACs for CSIAddonsNode #82

Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Feb 18, 2025

This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph#204

@black-dragon74 please add the Jira number to the PR title to get this PR merged

black-dragon74 and others added 2 commits February 18, 2025 10:21
This patch adds `watch` and `list` verbs for CSIAddonsNode objects.

These permissions are required by the csi-addons sidecar.
Ref: csi-addons/kubernetes-csi-addons#765

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit a0d2dc6)
generated bundle changes for the csiaddons
rbac.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1
Copy link
Member Author

Madhu-1 commented Feb 18, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 18, 2025

@Madhu-1: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@black-dragon74
Copy link
Member

black-dragon74 commented Feb 18, 2025

/retitle DFBUGS-848: [release-4.18] csi: update RBACs for CSIAddonsNode

@openshift-ci openshift-ci bot changed the title csi: update RBACs for CSIAddonsNode DFBUGS-848: [release-4.18] csi: update RBACs for CSIAddonsNode Feb 18, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Feb 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025

@Madhu-1: This pull request references [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph#204

@black-dragon74 please add the Jira number to the PR title to get this PR merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@black-dragon74
Copy link
Member

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 18, 2025

@black-dragon74: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Madhu-1 Madhu-1 added the lgtm label Feb 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 803c9f1 into red-hat-storage:release-4.18 Feb 18, 2025
13 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025

@Madhu-1: [Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-848](https://issues.redhat.com//browse/DFBUGS-848) has been moved to the MODIFIED state.

In response to this:

This patch adds list and watch verbs to cephfs and rbd provisioners that are required to recreate the csiaddosnode object when they are deleted under unwanted circumferences. This is required for csi-addos to work properly after csi-addons/kubernetes-csi-addons#765 is merged same changes are made in cephcsi operator as well ceph#204

@black-dragon74 please add the Jira number to the PR title to get this PR merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants