Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for ceph-csi-operator #83

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

iPraveenParihar and others added 3 commits February 25, 2025 10:46
Previously, the function incorrectly checked if `len(options) == 0`,
causing it to return a non-empty argument when no options were provided.
This fix updates the condition to `len(options) > 0`, ensuring the argument
is only set when options exist.

Signed-off-by: Praveen M <m.praveen@ibm.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
…rmat

csi: correct conditional logic for fuse mount options argument
@Madhu-1
Copy link
Member

Madhu-1 commented Feb 25, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 681b4b4 into main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants