Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-942: csi: provide delete access to csiaddonsnode #786

Closed

Conversation

subhamkrai
Copy link

csiaddons sidecar needs the delete RBAC
to set the ownerRef on the csiaddonsnode
object.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit b34c0b9) (cherry picked from commit 25e9243)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

csiaddons sidecar needs the delete RBAC
to set the ownerRef on the csiaddonsnode
object.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit b34c0b9)
(cherry picked from commit 25e9243)
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Nov 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

csiaddons sidecar needs the delete RBAC
to set the ownerRef on the csiaddonsnode
object.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit b34c0b9) (cherry picked from commit 25e9243)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@subhamkrai
Copy link
Author

@subhamkrai: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

@Madhu-1 PTAL

@travisn
Copy link

travisn commented Dec 2, 2024

@subhamkrai This fix is in the release-1.16 branch, right? Let's resync from 1.16 --> 4.18, instead of opening direct PRs.

Copy link

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resync instead

@agarwal-mudit
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2024

@agarwal-mudit: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Dec 3, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@agarwal-mudit: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agarwal-mudit
Copy link
Member

@travisn We should be cherry-picking now and not resync. Please correct me if I am missing something here

@Madhu-1
Copy link
Member

Madhu-1 commented Dec 3, 2024

@travisn We should be cherry-picking now and not resync. Please correct me if I am missing something here

we are doing the same in other repo's as well for 4.18 (cherry-picking)

@agarwal-mudit
Copy link
Member

/retest

@agarwal-mudit agarwal-mudit added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 3, 2024
Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Madhu-1
Copy link
Member

Madhu-1 commented Dec 3, 2024

/hold

@agarwal-mudit failure seems to be expected as the is no change in the csv for the relevant change. cc @sp98

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2024
@parth-gr
Copy link
Member

parth-gr commented Dec 3, 2024

closing in reference of #787

/close

Copy link

openshift-ci bot commented Dec 3, 2024

@parth-gr: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

closing in reference of #787

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Dec 3, 2024

/close

Copy link

openshift-ci bot commented Dec 3, 2024

@Madhu-1: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@subhamkrai
Copy link
Author

Closing the PR based on discussion.

@subhamkrai subhamkrai closed this Dec 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942). The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

csiaddons sidecar needs the delete RBAC
to set the ownerRef on the csiaddonsnode
object.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit b34c0b9) (cherry picked from commit 25e9243)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug jira/valid-reference lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants