-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-942: csi: provide delete access to csiaddonsnode #786
DFBUGS-942: csi: provide delete access to csiaddonsnode #786
Conversation
@subhamkrai: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Madhu-1 PTAL |
@subhamkrai This fix is in the release-1.16 branch, right? Let's resync from 1.16 --> 4.18, instead of opening direct PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resync instead
/jira refresh |
@agarwal-mudit: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942), which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@travisn We should be cherry-picking now and not resync. Please correct me if I am missing something here |
we are doing the same in other repo's as well for 4.18 (cherry-picking) |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold @agarwal-mudit failure seems to be expected as the is no change in the csv for the relevant change. cc @sp98 |
closing in reference of #787 /close |
@parth-gr: You can't close an active issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/close |
@Madhu-1: You can't close an active issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closing the PR based on discussion. |
@subhamkrai: This pull request references [Jira Issue DFBUGS-942](https://issues.redhat.com//browse/DFBUGS-942). The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
csiaddons sidecar needs the delete RBAC
to set the ownerRef on the csiaddonsnode
object.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit b34c0b9) (cherry picked from commit 25e9243)
Checklist: