-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-1592: nfs: workaround broken nfs-ganesha config parser #826
DFBUGS-1592: nfs: workaround broken nfs-ganesha config parser #826
Conversation
NFS-Ganesha introduced a breaking change in its config parser that no longer accepts single quotes around values. This seems to be working for most Ceph release images, but this was seen in at least one dev build of Ceph. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com> (cherry picked from commit 55d1a86) (cherry picked from commit 786a6bc)
@BlaineEXE: This pull request references [Jira Issue DFBUGS-1592](https://issues.redhat.com//browse/DFBUGS-1592), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@Madhu-1: This pull request references [Jira Issue DFBUGS-1592](https://issues.redhat.com//browse/DFBUGS-1592), which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ammahapa@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approved |
/approve |
@parth-gr: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BlaineEXE, Madhu-1, parth-gr, sp98, subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
232525b
into
red-hat-storage:release-4.18
@BlaineEXE: [Jira Issue DFBUGS-1592](https://issues.redhat.com//browse/DFBUGS-1592): All pull requests linked via external trackers have merged: [Jira Issue DFBUGS-1592](https://issues.redhat.com//browse/DFBUGS-1592) has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
NFS-Ganesha introduced a breaking change in its config parser that no longer accepts single quotes around values. This seems to be working for most Ceph release images, but this was seen in at least one dev build of Ceph.
Signed-off-by: Blaine Gardner blaine.gardner@ibm.com
(cherry picked from commit 55d1a86) (cherry picked from commit 786a6bc)
Checklist: