csi: create only required resource in external mode #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In downstream external mode, we'll only create required csi-operator resources like ceph connection and client profile CR's. Signed-off-by: subhamkrai <srai@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: subhamkrai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Madhu-1
reviewed
Mar 12, 2025
| @@ -297,7 +297,7 @@ func (r *ReconcileCephBlockPoolRadosNamespace) reconcile(request reconcile.Reque | |||
|
|
|||
| r.updateStatus(r.client, namespacedName, cephv1.ConditionReady) | |||
|
|
|||
| if csi.EnableCSIOperator() { | |||
| if csi.EnableCSIOperator() || cephCluster.Spec.External.Enable { | |||
There was a problem hiding this comment.
what happens if csi operator is disabled and its an external ceph cluster?
There was a problem hiding this comment.
ha okay, its downstream only change. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In downstream external mode, we'll only create required csi-operator resources like ceph connection and client profile CR's.
Checklist: