Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sending publish resolution on SDP + testbed settings. #613

Open
wants to merge 1 commit into
base: epic/AEGEAN
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "red5pro-html-sdk-testbed",
"version": "14.0.0",
"version": "14.1.0",
"description": "Testbed examples for Red5 Pro HTML SDK",
"main": "src/js/index.js",
"repository": {
Expand Down
10 changes: 10 additions & 0 deletions src/page/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ <h2 class="centered">WebRTC Specific</h2>
<label class="settings-label">Switch to Data Channel After Connection:</label>
<input type="checkbox" id="rtc-signal-socket-field" style="vertical-align: middle;">
</p>
<p class="settings-field settings-collapsable settings-field-row">
<label class="settings-label">Include Resolution in Offer:</label>
<input type="checkbox" id="include-resolution-offer-field" style="vertical-align: middle;">
</p>
<hr class="paddedHR" />
<h2 class="centered">Stream Manager Specific</h2>
<p class="settings-field settings-collapsable">
Expand Down Expand Up @@ -260,6 +264,7 @@ <h2 class="centered">Mixer Specific</h2>
var rtcTransportPolicySelect = document.getElementById('rtc-transport-policy');
var rtcpMuxPolicySelect = document.getElementById('rtc-mux-policy');
var rtcSignalSocketField = document.getElementById('rtc-signal-socket-field');
var includeResolutionOfferField = document.getElementById('include-resolution-offer-field');
var whipWhepField = document.getElementById('whipwhep-field');
var sessionHostField = document.getElementById('session-host-field');
var trickleField = document.getElementById('trickle-field');
Expand Down Expand Up @@ -381,6 +386,10 @@ <h2 class="centered">Mixer Specific</h2>
configuration.enableChannelSignaling = rtcSignalSocketField.checked;
seal(configuration);
});
includeResolutionOfferField.addEventListener('change', function () {
configuration.offerSDPResolution = includeResolutionOfferField.checked;
seal(configuration);
});
whipWhepField.addEventListener('change', () => {
configuration.preferWhipWhep = whipWhepField.checked;
seal(configuration);
Expand Down Expand Up @@ -506,6 +515,7 @@ <h2 class="centered">Mixer Specific</h2>
iceCredential.value = config.rtcConfiguration.iceServers[0].credential || '';
rtcCandidatePoolSize.value = config.rtcConfiguration.iceCandidatePoolSize || 0;
rtcSignalSocketField.checked = config.signalingSocketOnly;
includeResolutionOfferField.checked = config.offerSDPResolution;
whipWhepField.checked = config.preferWhipWhep || false;
sessionHostField.checked = config.disableProxy || false;
trickleField.checked = config.trickleIce || false;
Expand Down
1 change: 1 addition & 0 deletions src/page/test/publishCodecSupport/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
}
try {
targetPublisher = preferWhipWhep ? new WHIPClient() : new RTCPublisher()
targetPublisher.on('*', onPublisherEvent)
await targetPublisher.initWithStream(rtcConfig, mediaStream)
await targetPublisher.publish()
onPublishSuccess(targetPublisher)
Expand Down
1 change: 0 additions & 1 deletion src/template/partial/top-bar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ https://www.red5.net">
<div class="primary-menu-container menu-items">
<p class="menu-resources">
<span>Resources</span>
<span><img src="/red5/images/arrow_down.svg" /></span>
</p>
<p class="menu-developers">
<a href="https://red5.net/docs">Developers</a>
Expand Down
4 changes: 2 additions & 2 deletions static/lib/red5pro/red5pro-sdk.min.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions static/script/testbed-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
mixerBackendSocketField: '',
mixerAuthenticationEnabled: false,
preferWhipWhep: true,
offerSDPResolution: false,
}

/**
Expand Down