Addressed review comments

Signed-off-by: Yi Cai <yicai@redhat.com>
redhat-developer · Sep 27, 2024 · 5ce1b0c · 5ce1b0c
1 parent 1496cf7
commit 5ce1b0c
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 25 deletions.
diff --git a/src/themes/rhdh/components.ts b/src/themes/rhdh/components.ts
@@ -191,19 +191,6 @@ export const components = (themeConfig: ThemeConfig): Components => {
     };
   }
 
-  // MUI checkbox
-  if (options.checkbox !== "mui") {
-    components.MuiCheckbox = {
-      styleOverrides: {
-        root: {
-          "&[class*='Mui-checked'][class*='MuiCheckbox-colorSecondary-']": {
-            color: rhdhPrimary.main,
-          },
-        },
-      },
-    };
-  }
-
   // MUI input fields
   if (options.inputs !== "mui") {
     components.MuiInputBase = {

diff --git a/src/themes/rhdh/darkTheme.test.ts b/src/themes/rhdh/darkTheme.test.ts
@@ -55,7 +55,7 @@ describe("customDarkTheme", () => {
         main: "#1FA7F8",
       },
       secondary: {
-        main: "#B2A3FF",
+        main: "#1FA7F8",
       },
       status: {
         aborted: "#9E9E9E",
@@ -100,8 +100,8 @@ describe("customDarkTheme", () => {
           focusVisibleBorder: "#ADD6FF",
         },
         secondary: {
-          main: "#B2A3FF",
-          focusVisibleBorder: "#D0C7FF",
+          main: "#1FA7F8",
+          focusVisibleBorder: "#ADD6FF",
         },
         cards: {
           headerTextColor: "#FFF",

diff --git a/src/themes/rhdh/darkTheme.ts b/src/themes/rhdh/darkTheme.ts
@@ -10,7 +10,7 @@ export const customDarkTheme = (): ThemeConfigPalette => {
       main: "#1FA7F8",
     },
     secondary: {
-      main: "#B2A3FF",
+      main: "#1FA7F8",
     },
     navigation: {
       background: "#0f1214",
@@ -49,8 +49,8 @@ export const customDarkTheme = (): ThemeConfigPalette => {
         focusVisibleBorder: "#ADD6FF",
       },
       secondary: {
-        main: "#B2A3FF",
-        focusVisibleBorder: "#D0C7FF",
+        main: "#1FA7F8",
+        focusVisibleBorder: "#ADD6FF",
       },
       cards: {
         headerTextColor: "#FFF",

diff --git a/src/themes/rhdh/lightTheme.test.ts b/src/themes/rhdh/lightTheme.test.ts
@@ -55,7 +55,7 @@ describe("customLightTheme", () => {
         main: "#0066CC",
       },
       secondary: {
-        main: "#8476D1",
+        main: "#0066CC",
       },
       status: {
         aborted: "#757575",
@@ -104,8 +104,8 @@ describe("customLightTheme", () => {
           focusVisibleBorder: "#0066CC",
         },
         secondary: {
-          main: "#8476D1",
-          focusVisibleBorder: "#8476D1",
+          main: "#0066CC",
+          focusVisibleBorder: "#0066CC",
         },
         cards: {
           headerTextColor: "#151515",

diff --git a/src/themes/rhdh/lightTheme.ts b/src/themes/rhdh/lightTheme.ts
@@ -10,7 +10,7 @@ export const customLightTheme = (): ThemeConfigPalette => {
       main: "#0066CC",
     },
     secondary: {
-      main: "#8476D1",
+      main: "#0066CC",
     },
     navigation: {
       background: "#222427",
@@ -53,8 +53,8 @@ export const customLightTheme = (): ThemeConfigPalette => {
         focusVisibleBorder: "#0066CC",
       },
       secondary: {
-        main: "#8476D1",
-        focusVisibleBorder: "#8476D1",
+        main: "#0066CC",
+        focusVisibleBorder: "#0066CC",
       },
       cards: {
         headerTextColor: "#151515",