Remove code that overrides the search bar background color #39
Conversation
|
New package is available at: |
christoph-jerolimov
force-pushed
the
remove-overriding-searchbar
branch
from
221c581 to
7528bf1
Compare
|
New package is available at: |
christoph-jerolimov
force-pushed
the
remove-overriding-searchbar
branch
from
7528bf1 to
dda2a45
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciiay, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
christoph-jerolimov
force-pushed
the
remove-overriding-searchbar
branch
from
dda2a45 to
d9d34b9
Compare
|
New changes are detected. LGTM label has been removed. |
|
New package is available at: |
|
I just rebased the PR to check if the npm (preview) package was build now correctly. |
christoph-jerolimov
merged commit 5adf42f
into
redhat-developer:main
The style is now already added in the home page
SearchBarcomponent: https://github.com/janus-idp/backstage-showcase/blob/main/plugins/dynamic-home-page/src/components/SearchBar.tsx#L9-L16In that component, we might use a better-existing theme prop, then hard coded values. But I don't think we need a "search border" color anymore.
/cc @ciiay