RHIDP-5409 Consistent titles and subtitles #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
themr0c
requested review from
hmanwani-rh,
linfraze,
jmagak,
Gerry-Forde and
pabel-rh
|
@themr0c are you able to resolve the build error and generate previews? |
themr0c
commented
Jan 14, 2025
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-832/ @ 01/31/25 14:04:38 |
pabel-rh
reviewed
Jan 27, 2025
linfraze
reviewed
Jan 27, 2025
Co-authored-by: Lindsey Frazier <lfrazier@redhat.com>
Co-authored-by: Lindsey Frazier <lfrazier@redhat.com>
Co-authored-by: Lindsey Frazier <lfrazier@redhat.com>
|
@themr0c: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Still missing: fix all the attributes defining the titles URLs. |
|
I will merge this now, configure Pantheon, and then update the URLs with the definitive and tested new Pantheon URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4, 1.5
Add the relevant labels to the Pull Request.
Issue: RHIDP-5409
Reminder: as it will change the title URLs, be mindful that we need to create redirections before merging to a published branch such as release-1.4.
Probably better to first merge to main and verify how Pantheon is effectively building the titles before asking for the redirections.
Therefore:
main.mainin Pantheon for release 1.5 without publishing. Change the title names as required.release-1.4branch, and change the title names in Pantheon as required.