Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies with referencing my-rhdh-secrets #918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ You can store the configuration for dynamic plugins in a `ConfigMap` object that

[NOTE]
====
If the `pluginConfig` field references environment variables, you must define the variables in your `my-rhdh-secrets` secret.
If the `pluginConfig` field references environment variables, you must define the variables in your {my-product-secrets} secret.
====

.Procedure
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ data:
<1> The base URL to the Kubernetes control plane. You can run the `kubectl cluster-info` command to get the base URL.
<2> Set the value of this parameter to `false` to enable the verification of the TLS certificate.
<3> Optional: The link to the Kubernetes dashboard managing the ARO cluster.
<4> Optional: Pass the service account token using a `K8S_SERVICE_ACCOUNT_TOKEN` environment variable that you can define in your `my-rhdh-secrets` secret.
<5> Pass the CA data using a `K8S_CONFIG_CA_DATA` environment variable that you can define in your `my-rhdh-secrets` secret.
<4> Optional: Pass the service account token using a `K8S_SERVICE_ACCOUNT_TOKEN` environment variable that you can define in your {my-product-secrets} secret.
<5> Pass the CA data using a `K8S_CONFIG_CA_DATA` environment variable that you can define in your {my-product-secrets} secret.

. Save the configuration changes.

Expand Down
8 changes: 4 additions & 4 deletions modules/installation/proc-deploy-rhdh-instance-gke.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ data:
----
--

. Create a Secret named `my-rhdh-secrets` and add a key named `BACKEND_SECRET` with a `Base64-encoded` string as value:
. Create a Secret named {my-product-secret} and add a key named `BACKEND_SECRET` with a `Base64-encoded` string as value:
+
--
.`my-rhdh-secrets` fragment
.{my-product-secrets} fragment
[source,yaml]
----
apiVersion: v1
kind: Secret
metadata:
name: my-rhdh-secrets
name: {my-product-secret}
stringData:
# TODO: See https://backstage.io/docs/auth/service-to-service-auth/#setup
BACKEND_SECRET: "xxx"
Expand Down Expand Up @@ -106,7 +106,7 @@ spec:
- name: "app-config-rhdh"
extraEnvs:
secrets:
- name: "my-rhdh-secrets"
- name: {my-product-secret}
----
--

Expand Down
6 changes: 3 additions & 3 deletions modules/installation/proc-rhdh-deploy-aks-operator.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -114,15 +114,15 @@ data:
----
--

. Create a Secret named `my-rhdh-secrets` and add a key named `BACKEND_SECRET` with a `Base64-encoded` string value as shown in the following example:
. Create a Secret named {my-product-secrets} and add a key named `BACKEND_SECRET` with a `Base64-encoded` string value as shown in the following example:
+
--
[source,yaml]
----
apiVersion: v1
kind: Secret
metadata:
name: my-rhdh-secrets
name: {my-product-secret}
stringData:
BACKEND_SECRET: "xxx"
----
Expand All @@ -146,7 +146,7 @@ spec:
- name: "app-config-rhdh"
extraEnvs:
secrets:
- name: "my-rhdh-secrets"
- name: {my-product-secret}
----
--

Expand Down