Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): middleware tests #2014

Closed
wants to merge 48 commits into from

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Nov 28, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Nov 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 28, 2024

/test all

Copy link
Contributor

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 28, 2024

/test all

Copy link
Contributor

Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

Copy link
Contributor

github-actions bot commented Feb 1, 2025

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Feb 1, 2025
@nilgaar nilgaar changed the title [WIP] middleware tests test(e2e): middleware tests Feb 5, 2025
@nilgaar
Copy link
Contributor Author

nilgaar commented Feb 5, 2025

/ok-to-test

@nilgaar
Copy link
Contributor Author

nilgaar commented Feb 5, 2025

/test all

@github-actions github-actions bot removed the Stale label Feb 6, 2025
@nilgaar
Copy link
Contributor Author

nilgaar commented Feb 6, 2025

/test all

1 similar comment
@nilgaar
Copy link
Contributor Author

nilgaar commented Feb 6, 2025

/test all

@nilgaar
Copy link
Contributor Author

nilgaar commented Feb 6, 2025

/test all

@nilgaar
Copy link
Contributor Author

nilgaar commented Feb 7, 2025

/test all

Copy link
Contributor

@nilgaar
Copy link
Contributor Author

nilgaar commented Feb 28, 2025

/retest

@gashcrumb
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved label Mar 6, 2025
@subhashkhileri
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb, subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gashcrumb,subhashkhileri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Mar 6, 2025

@josephca
Copy link
Collaborator

Hi @subhashkhileri can you confirm if this PR is ready to be merged? (you added 'hold'). If then please 'unhold' it so that it can be merged. Thanks,

Copy link
Contributor

Copy link
Contributor

@subhashkhileri
Copy link
Member

Hi @subhashkhileri can you confirm if this PR is ready to be merged? (you added 'hold'). If then please 'unhold' it so that it can be merged. Thanks,

@josephca @nilgaar is working on a comment : #2014 (comment)

@josephca
Copy link
Collaborator

Hi @subhashkhileri can you confirm if this PR is ready to be merged? (you added 'hold'). If then please 'unhold' it so that it can be merged. Thanks,

@josephca @nilgaar is working on a comment : #2014 (comment)

@subhashkhileri Nil is no longer working on this. Do you know what is remained?

Copy link
Contributor

@subhashkhileri
Copy link
Member

Hi @subhashkhileri can you confirm if this PR is ready to be merged? (you added 'hold'). If then please 'unhold' it so that it can be merged. Thanks,

@josephca @nilgaar is working on a comment : #2014 (comment)

@subhashkhileri Nil is no longer working on this. Do you know what is remained?

@josephca this was the issue I was talking about with @nilgaar #2014 (comment)

@josephca josephca mentioned this pull request Mar 20, 2025
5 tasks
@josephca
Copy link
Collaborator

This PR is replaced by #2609. Closing it.

@josephca josephca closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants