OPCT-226: opct adm parsers for etcd and metrics #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
mtulio
force-pushed
the
feat-report-opct-adm
branch
from
0943488 to
ea8f0f2
Compare
mtulio
changed the title
mtulio
force-pushed
the
feat-report-opct-adm
branch
3 times, most recently
from
003f171 to
5c6fb33
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mtulio
added
kind/feature
|
/assign @jcpowermac @rvanderp3 |
mtulio
force-pushed
the
feat-report-opct-adm
branch
from
5c6fb33 to
10ccbd1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Converting to draft to rebase, improve CI workflow to bump to 1.22 - and convert the go version into variable. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
do-not-merge/work-in-progress
mtulio
force-pushed
the
feat-report-opct-adm
branch
2 times, most recently
from
3f439e7 to
3d3d425
Compare
Introduce 'adm' subcommand support, with parser as a child to allow users to consume subset of features from 'report' command individually when need to explore individual archives, like must-gather, metrics, etc.
Create the libraries used to extract, process, and create reports for the 'opct adm parse-*' commands. Those libraries are extracted from 'opct report' (WIP redhat-openshift-ecosystem#26) created to produce the final report when processing the result archive.
Introduce VFS and test data to be consumed by CI/e2e and unit tests.
mtulio
force-pushed
the
feat-report-opct-adm
branch
from
3d3d425 to
d57af0e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mtulio
force-pushed
the
feat-report-opct-adm
branch
6 times, most recently
from
16fd08d to
a208098
Compare
mtulio
commented
Jul 10, 2024
mtulio
commented
Jul 10, 2024
Introduce new CI/GHA jobs to test new opct adm commands. Standarize/upgrade old action images to prevent deprecation warnings.
mtulio
force-pushed
the
feat-report-opct-adm
branch
from
a208098 to
7084c4a
Compare
|
Considering the amount of pending tasks/workload in this project, specially for v0.5, and the current bandwith to review, I am moving on this PR and merge it. This PR is introduce new command and capabilities to parse data, introducing new e2e using test data which isn't yet available, it may provides good signal to proceed. This PR is blocking v0.5, and it is a subset of #76. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the following commands to consume subset of features introduced on
opct report(v0.5+, #76):opct adm parse-etcd-logs: parse logs from etcd pod logs from must-gather providing a summary w/ timers from the cluster oprationopct adm parse-metrics: parse metrics read from Prometheus collected by OPCT and generate charts in HTML filesThe commands are a subset of improvements in UI (CLI and Web) of
opct reportthat is planning to be available in the stable of v0.5. This subset of changes were extracted from under development OPCT report PR: #76