Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support info #29

Merged
merged 2 commits into from
Feb 28, 2025
Merged

add support info #29

merged 2 commits into from
Feb 28, 2025

Conversation

mjiao
Copy link
Contributor

@mjiao mjiao commented Feb 28, 2025

No description provided.

@mjiao mjiao requested review from kksat and RishabhKodes February 28, 2025 14:32
kksat
kksat previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@kksat kksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the changes proposed. Not sure that we should advertise for 3rd party support even for 3rd party components.

RishabhKodes
RishabhKodes reviewed Feb 28, 2025
View reviewed changes
kksat
kksat approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@kksat kksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjiao
Copy link
Contributor Author

mjiao commented Feb 28, 2025

I am fine with the changes proposed. Not sure that we should advertise for 3rd party support even for 3rd party components.
Thank you for reviewing. Since Red Hat doesn't provide direct services like these components, it's acceptable to reference third-party solutions. However, it's crucial to clearly define support responsibilities to ensure all stakeholders understand their roles.

mjiao and others added 2 commits February 28, 2025 16:50
@mjiao
add support info
6858f6e 
Signed-off-by: mjiao <manjun.jiao@gmail.com>
@mjiao @RishabhKodes
Apply suggestions from code review
abe8351 
Co-authored-by: Rishabh Bhandari <41220684+RishabhKodes@users.noreply.github.com>
Signed-off-by: mjiao <manjun.jiao@gmail.com>
@mjiao mjiao merged commit 9b9df1a into redhat-sap:main Feb 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RishabhKodes RishabhKodes RishabhKodes left review comments

@kksat kksat kksat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjiao @kksat @RishabhKodes