Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build config (Preparation for Kotlin Multiplatform) #63

Merged

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Apr 9, 2024

Preparation for Kotlin Multiplatform

#57

This PR contains improvements for the project's build logic.

Summary

  • update Kotlin to 1.9.23 (but keep the language level at 1.6, so there are no code changes)
  • update to Gradle 8.7
  • create buildSrc convention plugins, so build logic can be more easily written and shared (the KMP one isn't used... yet!)
  • add gradle.properties, enable build cache, config cache
  • simplify some build logic (e.g. use withSourcesJar() for the sources JAR)

This is a build-logic only change. There should be no impact on the published artifacts.

TODO

  • I saw that gradle.properties was in .gitignore, which is unusual. Do you use it to store credentials? If so, you can move the credentials to ~./gradle/git.properties, and Gradle will pick them up.
  • I've broken the changes down into 4 PRs. Maybe you want to merge each one into the main branch, but it would also make sense if you created a kmp branch, and we can merge each PR into the kmp branch until they're all done?

- Gradle 8.7
- create convention plugins
- add gradle.properties, enable build cache, config cache
- simplify some build logic (e.g. sources jar)
@aSemy aSemy changed the title update build config (prep for KMP) Update build config (Preparation for Kotlin Multiplatform) Apr 9, 2024
@redundent redundent changed the base branch from main to kotlin-multiplatform April 12, 2024 13:50
@aSemy aSemy requested a review from redundent April 15, 2024 13:42
@redundent redundent merged commit 4da164c into redundent:kotlin-multiplatform Apr 16, 2024
@aSemy aSemy deleted the feat/update-build-config branch April 16, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants