Merge pull request #38 from reef-pi/fix_race_condition

(bug)take lock before reading map value in noop pwm driver
reef-pi · Jan 16, 2022 · 9ab406e · 9ab406e
2 parents 95fff2a + 03ca8c9
commit 9ab406e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -9,5 +9,5 @@ jobs:
         with:
           go-version: '^1.16.1'
       - uses: codecov/codecov-action@v1
-      - run: go test ./...
+      - run: go test -cover -race ./...
       - run: go build ./...
diff --git a/pwm/noop_driver.go b/pwm/noop_driver.go
@@ -25,7 +25,10 @@ func Noop() (Driver, *recorder) {
 			return nil
 		},
 		readFile: func(f string) ([]byte, error) {
-			if _, ok := rec.values[f]; !ok {
+			rec.mu.Lock()
+			_, ok := rec.values[f]
+			rec.mu.Unlock()
+			if !ok {
 				return []byte{}, nil
 			}
 			return rec.values[f], nil