Testing on unicode converters can be disabled on CMake (can be a temp…

…orary fix for CI on WIndows)
reefactor · Sep 2, 2024 · 07155d7 · 07155d7
1 parent 36aada5
commit 07155d7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -2,6 +2,14 @@ add_executable(tests tests.cpp)
 target_link_libraries(tests cppy3)
 include_directories(${PROJECT_SOURCE_DIR})
 
+option(CPPY3_TEST_UNICODE_CONVERTERS "Test for proper working of Unicode conversion utilities" ON)
+
+if(CPPY3_TEST_UNICODE_CONVERTERS)
+    add_definitions(-DTEST_UNICODE_CONVERTERS)
+else()
+    add_definitions(-DTEST_UNICODE_CONVERTERS=0)
+endif()
+
 if(Python3_NumPy_FOUND)
     include_directories(${Python3_NumPy_INCLUDE_DIRS})
     if(WIN32)

diff --git a/tests/tests.cpp b/tests/tests.cpp
@@ -10,15 +10,17 @@
 #define CATCH_CONFIG_MAIN
 #include <catch2/catch.hpp>
 
-#define DEBUG_UNICODE_CONVERTERS 1
+#ifndef TEST_UNICODE_CONVERTERS
+#define TEST_UNICODE_CONVERTERS 1
+#endif
 
 
 TEST_CASE( "Utils", "" ) {
+#if TEST_UNICODE_CONVERTERS
   SECTION( "unicode converters" ) {
     const std::string utf8Str("зачем вы посетили нас в глуши забытого селенья");
     const std::wstring unicodeStr(L"зачем вы посетили нас в глуши забытого селенья");
 
-#if DEBUG_UNICODE_CONVERTERS
 #if 1
     constexpr char locale_name[] = "en_US.UTF-8";
     setlocale( LC_ALL, locale_name );
@@ -37,11 +39,11 @@ TEST_CASE( "Utils", "" ) {
 
     std::wcout << unicodeStr << std::endl;
     std::wcout << "UTF8->Unicode:" << cppy3::UTF8ToWide(utf8Str) << std::endl;
-#endif
 
     REQUIRE(cppy3::WideToUTF8(unicodeStr) == utf8Str);
     REQUIRE(cppy3::UTF8ToWide(utf8Str) == unicodeStr);
   }
+#endif
 }
 
 TEST_CASE( "cppy3: Embedding Python into C++ code", "main funcs" ) {