Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solvability implementation for rattler-build #58

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Sep 20, 2024

No description provided.

@wolfv
Copy link
Contributor Author

wolfv commented Sep 20, 2024

Alright, this works! :) Will have to come up with some unsovlable ones for a test.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suppress_output() context needs to be added back in the correct spots.

@wolfv
Copy link
Contributor Author

wolfv commented Sep 21, 2024

I restored the output supression. I think from my end this doesn't really need more work.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. A few more items.

  • The print statements need to be changed to print_debug

  • we need a test with an unsolvable recipe that shows what the output looks like.

@wolfv
Copy link
Contributor Author

wolfv commented Sep 22, 2024

The error looks something like:

osx_arm64_: Rattler build errors: ╭─ Finding outputs from recipe
 │ Found 1 variants
 │ Build variant: v1-unsolvable-0.1-py100hfde170a_0
 │ 
 │ ╭─────────────────┬───────────╮
 │ │ Variant         ┆ Version   │
 │ ╞═════════════════╪═══════════╡
 │ │ python          ┆ 100       │
 │ │ target_platform ┆ osx-arm64 │
 │ ╰─────────────────┴───────────╯
 │
 ╰─────────────────── (took 0 seconds)

 ╭─ Resolving environments
 │ 
 │ Resolving environment for:
 │   Platform: osx-arm64
 │   Channels: 
 │    - file:///Users/wolfv/Programs/conda-forge/conda-forge-feedstock-check-solvable/output/
 │    - file:///var/folders/ls/nd2_c1qn1tz8c8sccxmg83m00000gn/T/tmppirjyobl/
 │    - conda-forge
 │    - file:///var/folders/ls/nd2_c1qn1tz8c8sccxmg83m00000gn/T/tmppirjyobl/
 │   Specs:
 │    - python 100.*
 │
 ╰─────────────────── (took 0 seconds)
Error:   × Failed to resolve dependencies: Cannot solve the request because of: No candidates were found for python 100.*.
  │ 
  ╰─▶ Cannot solve the request because of: No candidates were found for python 100.*.

I think that should be fine - wdyt?

@wolfv
Copy link
Contributor Author

wolfv commented Sep 22, 2024

Also removed print statements / replaced with print_debug.

@wolfv wolfv changed the title WIP: solvability implementation for rattler-build feat: solvability implementation for rattler-build Sep 23, 2024
@beckermr beckermr merged commit a32add4 into regro:main Sep 23, 2024
3 checks passed
@wolfv wolfv deleted the rattler-build-check branch September 23, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants