Make some initial fixes get core compiling
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
force-pushed
the
wip/ara/compiling-core
branch
from
729619f to
63b5b11
Compare
Eagle941
reviewed
Jan 29, 2025
Eagle941
approved these changes
Jan 29, 2025
|
LGTM! |
This commit is a grab-bag of smaller fixes required to get Rust's `core` library compiling properly by hieratika. They include: - Adding support for an `i48` type which seems to be required, as well as adding polyfill stubs for such a type. - Adding support for an `i40` type which seems to be required, as well as adding polyfill stubs for such a type. - Changing the `DataLayout` type's query functionality to comply with the layout promotion rules for integers. - Registers all variables inside a function ahead of time to cope with usages before declaration in lexical order but not in execution order. - Changes the handling of GetElementPtr instructions to account for negative indices, which were not apparently allowed from the LangRef, but are encountered in `core`. As GetElementPtr does not access memory, it does make sense that they are allowed, so we now support them here.
iamrecursion
force-pushed
the
wip/ara/compiling-core
branch
from
63b5b11 to
1714f13
Compare
ktemkin
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit is a grab-bag of smaller fixes required to get Rust's
corelibrary compiling properly by hieratika. They include:i48type which seems to be required, as well as adding polyfill stubs for such a type.i40type which seems to be required, as well as adding polyfill stubs for such a type.DataLayouttype's query functionality to comply with the layout promotion rules for integers.core. As GetElementPtr does not access memory, it does make sense that they are allowed, so we now support them here.Details
Just the usual checks, please!
Checklist
scarb fmt.