refactor(ProxyGeneratorInterface): Remove ProxySpecification.

CHANGELOG.md

@@ -6,6 +6,7 @@
 * refactor(`MainTransformer`): Move to implementation namespace.
 * refactor: Move proxy creation code to `ProxyFactory`.
 * feat(`SubMapperInterface`): Add `createProxy()`.
+* refactor(`ProxyGeneratorInterface`): Remove `ProxySpecification`.
 
 ## 0.10.0
 

src/Proxy/Implementation/DoctrineProxyGenerator.php

@@ -16,7 +16,6 @@
 use Doctrine\Persistence\ManagerRegistry;
 use Rekalogika\Mapper\Proxy\Exception\ProxyNotSupportedException;
 use Rekalogika\Mapper\Proxy\ProxyGeneratorInterface;
-use Rekalogika\Mapper\Proxy\ProxySpecification;
 
 /**
  * Prevent proxy creation for Doctrine entities.
@@ -31,14 +30,14 @@ public function __construct(
     ) {
     }
 
-    public function generateProxy(string $class): ProxySpecification
+    public function generateProxyCode(string $realClass, string $proxyClass): string
     {
-        $manager = $this->managerRegistry->getManagerForClass($class);
+        $manager = $this->managerRegistry->getManagerForClass($realClass);
 
         if ($manager) {
-            throw new ProxyNotSupportedException($class, reason: 'Doctrine entities do not support proxying.');
+            throw new ProxyNotSupportedException($realClass, reason: 'Doctrine entities do not support proxying.');
         }
 
-        return $this->decorated->generateProxy($class);
+        return $this->decorated->generateProxyCode($realClass, $proxyClass);
     }
 }

src/Proxy/Implementation/ProxyFactory.php

@@ -45,8 +45,9 @@ public function createProxy(
         $targetProxyClass = ProxyNamer::generateProxyClassName($class);
 
         if (!class_exists($targetProxyClass, false)) {
-            $proxySpecification = $this->proxyGenerator->generateProxy($class);
-            $this->proxyRegistry->registerProxy($proxySpecification);
+            $sourceCode = $this->proxyGenerator
+                ->generateProxyCode($class, $targetProxyClass);
+            $this->proxyRegistry->registerProxy($targetProxyClass, $sourceCode);
 
             if (!class_exists($targetProxyClass)) {
                 throw new LogicException(

src/Proxy/Implementation/ProxyGenerator.php

@@ -15,8 +15,6 @@
 
 use Rekalogika\Mapper\Proxy\Exception\ProxyNotSupportedException;
 use Rekalogika\Mapper\Proxy\ProxyGeneratorInterface;
-use Rekalogika\Mapper\Proxy\ProxyNamer;
-use Rekalogika\Mapper\Proxy\ProxySpecification;
 use Symfony\Component\VarExporter\Exception\LogicException;
 use Symfony\Component\VarExporter\ProxyHelper;
 
@@ -25,28 +23,26 @@
  */
 final readonly class ProxyGenerator implements ProxyGeneratorInterface
 {
-    public function generateProxy(string $class): ProxySpecification
-    {
-        /** @var class-string */
-        $proxyClass = ProxyNamer::generateProxyClassName($class);
-
+    public function generateProxyCode(
+        string $realClass,
+        string $proxyClass
+    ): string {
         try {
-            $proxyCode = $this->generateProxyCode($class);
+            $proxyCode = $this->generateProxySourceCode($realClass, $proxyClass);
         } catch (LogicException $e) {
-            throw new ProxyNotSupportedException($class, previous: $e);
+            throw new ProxyNotSupportedException($realClass, previous: $e);
         }
 
-        return new ProxySpecification($proxyClass, $proxyCode);
+        return $proxyCode;
     }
 
     /**
-     * @param class-string $class
+     * @param class-string $realClass
      * @return string
      */
-    private function generateProxyCode(string $class): string
+    private function generateProxySourceCode(string $realClass, string $proxyClass): string
     {
-        $proxyClass = ProxyNamer::generateProxyClassName($class);
-        $targetReflection = new \ReflectionClass($class);
+        $targetReflection = new \ReflectionClass($realClass);
 
         // get proxy class name & namespace
         $shortName = preg_replace('/.*\\\\/', '', $proxyClass);

src/Proxy/Implementation/ProxyRegistry.php

@@ -15,7 +15,6 @@
 
 use Rekalogika\Mapper\Proxy\ProxyAutoloaderInterface;
 use Rekalogika\Mapper\Proxy\ProxyRegistryInterface;
-use Rekalogika\Mapper\Proxy\ProxySpecification;
 
 /**
  * @internal
@@ -34,18 +33,15 @@ public function __construct(
         }
     }
 
-    public function registerProxy(
-        ProxySpecification $proxySpecification,
-    ): void {
-        $proxyClass = $proxySpecification->getClass();
-
+    public function registerProxy(string $class, string $sourceCode): void
+    {
         $proxyFile = sprintf(
             '%s/%s',
             $this->proxyDirectory,
-            self::getProxyFileName($proxyClass)
+            self::getProxyFileName($class)
         );
 
-        file_put_contents($proxyFile, $proxySpecification->getCode());
+        file_put_contents($proxyFile, $sourceCode);
     }
 
     public function registerAutoloader(): void

src/Proxy/ProxyGeneratorInterface.php

@@ -18,8 +18,8 @@
 interface ProxyGeneratorInterface
 {
     /**
-     * @param class-string $class
+     * @param class-string $realClass
      * @throws ProxyNotSupportedException
      */
-    public function generateProxy(string $class): ProxySpecification;
+    public function generateProxyCode(string $realClass, string $proxyClass): string;
 }

src/Proxy/ProxyNamer.php

@@ -20,7 +20,6 @@ class ProxyNamer
 {
     /**
      * @param class-string $class
-     * @return string
      */
     public static function generateProxyClassName(string $class): string
     {

src/Proxy/ProxyRegistryInterface.php

@@ -18,7 +18,5 @@
  */
 interface ProxyRegistryInterface
 {
-    public function registerProxy(
-        ProxySpecification $proxySpecification,
-    ): void;
+    public function registerProxy(string $class, string $sourceCode): void;
 }