Add potential fix for bug with flash render #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fix for render _flash
dalvarez2596
reviewed
Dec 7, 2024
There was a problem hiding this comment.
Hi @KimboGilda is awesome what you did, I tried and the flash notifications and looks nice:
Screen.Recording.2024-12-07.at.3.41.27.PM.mov
With smaller names:
Screen.Recording.2024-12-07.at.3.48.22.PM.mov
Just add some small comments, but nicely done.
| <% end %> | ||
| <div id="flash-messages"> | ||
| <% flash.each do |type, msg| %> | ||
| <div class = "flash" |
There was a problem hiding this comment.
What Ill suggest is to move the styles from here to the application.css, as the current styles are implemented. To maintain the same format.
There was a problem hiding this comment.
Also i think that you need to check this change, I don't think is necessary on this PR.
|
Closing this in favour of #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.