Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various fixes #153

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: various fixes #153

wants to merge 4 commits into from

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Mar 19, 2025

Resolves WK-608
Resolves WK-605

@chris13524 chris13524 self-assigned this Mar 19, 2025
Copy link

linear bot commented Mar 19, 2025

@chris13524 chris13524 marked this pull request as ready for review March 19, 2025 21:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses fixes for WK-608 and WK-605 by updating constant names and import statements, refining the wallet service API parameter handling, and enhancing test coverage for error serialization and deserialization.

  • Updated constant naming for Solana chain identifiers and adjusted related references.
  • Refined wallet provider URL handling and query parameter construction.
  • Added tests for unknown bridging error roundtrip serialization.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/yttrium/src/chain_abstraction/solana/tests.rs Updated imports and adjusted wallet provider URL construction.
crates/yttrium/src/chain_abstraction/api/prepare.rs Added tests to validate bridging error serialization and deserialization.
crates/yttrium/src/chain_abstraction/error.rs Enhanced error variant for transaction failures with tx hash inclusion.
crates/yttrium/src/wallet_service_api.rs Modified metadata structs with new fields and adjusted derivations.
crates/yttrium/src/chain_abstraction/solana/mod.rs Introduced const_format for generating CAIP2 identifier and updated constants.
crates/yttrium/Cargo.toml Added new dependency (const_format).
crates/yttrium/src/chain_abstraction/tests.rs Updated references to the renamed Solana chain constant.
crates/yttrium/src/provider_pool.rs Changed parameter for get_wallet_provider reflecting URL override type.
crates/yttrium/src/chain_abstraction/send_transaction.rs Updated error instantiation to include the transaction hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant