Java 17 #356
Merged
Java 17 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the value in requiring Java 17? Was a blocker for something big rewrite / addition? |
xabolcs
added a commit
to xabolcs/re-play1
that referenced
this pull request
Apr 17, 2024
As stated in replay-framework#356, the following libraries require Java 17: * ECJ (Eclipse java compiler, fastergt - the default template enginge) * FlyingSaucer (PDF generation) * Selenide (UI tests) The helloworld-kotlin test project had to be manually adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Replay will require at least Java 17.
Before this change, Replay worked on Java 11.