-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 4 themes by Scout339 #100
Conversation
I'm starting to see why GIT is so powerful.
Congrats on your first PR! The theme folder names should be lowercase rather then uppercase as seen in the other themes, but it otherwise looks good. Please fix that and I'll merge it. |
First merge request had uppercase letters for folder names. Fixed and attempting merge.
Alright, I'm pretty sure I made the changes correctly. Strange that it mentions deleting something that was never merged to the original project as a change to merge, but the syntax for the themes should be correct! |
Git and GitHub copy can be a tad unintuitive, but all your changes were good to go. Your themes should be appearing on Discover shortly. :) |
More themes!
Hello! first time forking and making a pull, hopefully I didn't do too much as an inexperience GIT user. Attempted to follow the contribution guidelines and built the themes on my personal machine before trying to learn the basics of Github to officially add some of my themes to the repo!