Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 4 themes by Scout339 #100

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Conversation

Scout339
Copy link
Contributor

@Scout339 Scout339 commented Feb 13, 2025

More themes!

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

Hello! first time forking and making a pull, hopefully I didn't do too much as an inexperience GIT user. Attempted to follow the contribution guidelines and built the themes on my personal machine before trying to learn the basics of Github to officially add some of my themes to the repo!

  • Dark Signal is the only one that I used some CSS for just to see what I could do with some limited knowledge, but is based off of the Signal Desktop app's official dark theme.
  • Paperwhite is a port of my Discord Light Theme 2.0 Concept (that actually was the inspiration for Discord to remake their Light Theme as it is now marked 'completed' on their forums! https://support.discord.com/hc/en-us/community/posts/360043415712-A-concept-to-improve-Discord-s-light-Theme)
  • Sonar was originally the start of Dark Signal, but I accidentally made something different and leaned into the difference in colors to end up making an entirely different theme.
  • Steamy is as close as I could get to porting the Steam Desktop App's color theme, and it ended up looking nice, so why not include it?

@DeclanChidlow DeclanChidlow self-requested a review February 13, 2025 09:03
@DeclanChidlow DeclanChidlow self-assigned this Feb 13, 2025
@DeclanChidlow
Copy link
Member

Congrats on your first PR!

The theme folder names should be lowercase rather then uppercase as seen in the other themes, but it otherwise looks good.

Please fix that and I'll merge it.

@Scout339
Copy link
Contributor Author

Alright, I'm pretty sure I made the changes correctly. Strange that it mentions deleting something that was never merged to the original project as a change to merge, but the syntax for the themes should be correct!

@DeclanChidlow DeclanChidlow merged commit 1d17bb1 into revoltchat:master Feb 13, 2025
1 check passed
@DeclanChidlow
Copy link
Member

Git and GitHub copy can be a tad unintuitive, but all your changes were good to go.

Your themes should be appearing on Discover shortly. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants